Make Testcontainers extension annotation public to allow using in ordered ExtendWith #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedla
force-pushed
the
issue-2045-public-extension
branch
from
f3d2fbb
to
220bf16
Compare
bedla
force-pushed
the
issue-2045-public-extension
branch
2 times, most recently
from
daba628
to
a001926
Compare
bedla
force-pushed
the
issue-2045-public-extension
branch
from
a001926
to
5c3ef67
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found fix of #2045 useful and created PR. My usecase could be found in TestcontainersSharedContainerWithGeneratedResourcesTests. Problem is that I want to have static containers that use some generated resources and without
@ExtendWithI am unable to tell order in which extensions are invoked.What do you think?
Thx
Ivos