Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display a stack trace in the logs when .testcontainers.properties is not found #2293

Merged
merged 10 commits into from
Oct 3, 2020
Merged

Don't display a stack trace in the logs when .testcontainers.properties is not found #2293

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e2e2d0
Fixing https://github.com/testcontainers/testcontainers-java/issues/2253
rishumehrotra Jan 27, 2020
36a8ef1
adding ExceptionUtils
rishumehrotra Jan 28, 2020
63f1cf6
Merge branch 'master' into bugfix/2253
rishumehrotra Feb 17, 2020
132742a
Merge branch 'master' into bugfix/2253
rnorth May 1, 2020
f798e5c
adding comments
rishumehrotra Aug 1, 2020
7c7bf03
fixing log.warn
rishumehrotra Aug 1, 2020
aa66bce
Merge branch 'master' into bugfix/2253
rishumehrotra Aug 1, 2020
dc94d89
Merge branch 'master' into bugfix/2253
rishumehrotra Aug 1, 2020
6f16c23
Merge branch 'master' into bugfix/2253
rnorth Oct 1, 2020
18c5d50
Merge branch 'master' into bugfix/2253
rnorth Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.google.common.annotations.VisibleForTesting;
import lombok.*;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang.exception.ExceptionUtils;
import org.testcontainers.UnstableAPI;

import java.io.*;
Expand Down Expand Up @@ -169,9 +170,9 @@ private static Properties readProperties(URL url) {
try (InputStream inputStream = url.openStream()) {
properties.load(inputStream);
} catch (FileNotFoundException e) {
log.trace("Testcontainers config override was found on {} but the file was not found", url, e);
log.warn("Testcontainers config override was found on {} but the file was not found", ExceptionUtils.getRootCauseMessage(e));
rishumehrotra marked this conversation as resolved.
Show resolved Hide resolved
} catch (IOException e) {
log.warn("Testcontainers config override was found on {} but could not be loaded", url, e);
log.warn("Testcontainers config override was found on {} but could not be loaded", ExceptionUtils.getRootCauseMessage(e));
}
return properties;
}
Expand Down