Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error related to unicode in source code #2464

Merged
merged 2 commits into from Jun 19, 2020
Merged

Fix compilation error related to unicode in source code #2464

merged 2 commits into from Jun 19, 2020

Conversation

trexinc
Copy link
Contributor

@trexinc trexinc commented Mar 20, 2020

There was a raw \ufe0e in the code, changed it to the escaped format. Otherwise the compilation failed on my system.

@stale
Copy link

stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jun 19, 2020
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I finally understand this: the U+fe0e character was in the code but invisible as whitespace. That character in unicode serves the purpose of forcing the previous glyph to be rendered as text, not an emoji - it was presumably inserted automatically by our IDEs when the line was first authored.

I'm fine with this - I've not seen this ever be a problem in any environment, but am happy to merge.

Thanks @trexinc, and sorry for taking time to realise what this PR is about.

@stale stale bot removed the stale label Jun 19, 2020
@rnorth rnorth merged commit 8767b86 into testcontainers:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants