Make default file recording directory of BrowserWebDriverContainer platform independent #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atform independent.
bsideup
reviewed
Apr 13, 2020
| @@ -79,6 +82,14 @@ public BrowserWebDriverContainer() { | |||
| .withStrategy(new HostPortWaitStrategy()) | |||
| .withStartupTimeout(Duration.of(15, SECONDS)); | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
IMO we should move it to configure and create the dir only if recording is enabled
|
/azp run "Windows 10 - Docker for Windows" |
|
No pipelines are associated with this pull request. |
|
/azp run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bsideup
reviewed
Apr 13, 2020
| @@ -52,6 +54,7 @@ | |||
| private static final int VNC_PORT = 5900; | |||
|
|
|||
| private static final String NO_PROXY_KEY = "no_proxy"; | |||
| public static final String TC_TEMP_DIR_PREFIX = "tc"; | |||
|
/azp run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bsideup
approved these changes
Apr 13, 2020
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…atform independent (testcontainers#2562) Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incompatibility of Windows with default recording directory, makes Windows work OOTB.
Not 100% sure how to best handle the
IOExceptionin the constructor.