Method to enable functions worker in pulsar container #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
May 13, 2020
modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java
Show resolved
Hide resolved
bsideup
reviewed
May 13, 2020
modules/pulsar/src/test/java/org/testcontainers/containers/PulsarContainerTest.java
Outdated
Show resolved
Hide resolved
This change should simplify a bit pulsar functions development experience Tried here: https://github.com/lanwen/pulsar-functions-example Without waiter pulsar could return random 503, depending on how fast was a call.
real functions upload test
|
@bsideup is anything I can do in this PR? |
|
@lanwen thanks for the ping! Just applied a minor change, will merge once CI is green 👍 |
bsideup
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should simplify a bit pulsar functions development experience
Tried here: https://github.com/lanwen/pulsar-functions-example
Without waiter pulsar could return random 503, depending on how fast
was a call.