Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest v5 release of release-drafter #2815

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Switch to latest v5 release of release-drafter #2815

merged 2 commits into from
Jun 1, 2020

Conversation

jetersen
Copy link
Contributor

👋 Hi we recently fixed some of the bugs you reported over at release-drafter. So here I am updating your action to get those patches.

release-drafter/release-drafter#412
release-drafter/release-drafter#424

@rnorth
Copy link
Member

rnorth commented May 30, 2020

Awesome, thank you @jetersen!

Just wondering - is there any specific need to specify the version as v5 rather than v5.9.0 (which seems the be the latest)?

I think I'd prefer to do this if we can so that we don't have a floating dependency version.

@jetersen
Copy link
Contributor Author

jetersen commented May 30, 2020

v5 points to the latest version of major version 5.
This is actually based on the recommended versioning for GitHub actions.

https://help.github.com/en/actions/creating-actions/about-actions#using-release-management-for-actions

of course your welcome to send the suggestion to fix the version to v5.9.0 though that would block for any new features or bug fixes 😅

.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@jetersen
Copy link
Contributor Author

jetersen commented Jun 1, 2020

Might be worthwhile waiting for the next release with release-drafter/release-drafter#546 incoming 😆

@kiview
Copy link
Member

kiview commented Jun 1, 2020

I think @rnorth mentioned a Dependabot feature for updating actions 🙂

@kiview kiview added this to the next milestone Jun 1, 2020
@kiview kiview merged commit 0eb2dea into testcontainers:master Jun 1, 2020
@jetersen jetersen deleted the patch-1 branch June 1, 2020 17:56
@bsideup bsideup modified the milestones: 1.14.3, next Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants