Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest LocalStack container and support unified port mode #2825

Merged
merged 28 commits into from
Jul 19, 2020
Merged

Update to latest LocalStack container and support unified port mode #2825

merged 28 commits into from
Jul 19, 2020

Conversation

artamonovkirill
Copy link
Contributor

  • Latest LocalStack default container.
  • Single port exposed and used for AWS endpoints.

@rnorth rnorth mentioned this pull request Jun 5, 2020
Merged
7 tasks
artamonovkirill and others added 22 commits June 7, 2020 00:09
@artamonovkirill
⬆️ latest default LocalStack container
858ec54
@artamonovkirill
♻️ rely on ComparableVersion for version comparison. added LocalStack…
b310e3e 
…Container(String version, boolean legacyMode) constructor. Extended test cases.
@artamonovkirill
✅ wait for pull and tag commands to finish
df1d96e
@rnorth
WIP
68ee3bc
@rnorth
WIP
46c7e1b
@rnorth
WIP
054b637
@rnorth
WIP
196f1a9
@rnorth
Tidy up test image references
f3fe807
@rnorth
Merge remote-tracking branch 'origin/master' into deprecate-ambiguous…
c523b38 
…-constructors

# Conflicts:
#	core/src/test/java/org/testcontainers/images/RemoteDockerImageTest.java
#	modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java
#	modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java
#	modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java
#	modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java
@rnorth
Update docs re contrainer creation and specifying versions
296f9f7
@rnorth
Update Javadocs with deprecation warnings.
aa94289
@rnorth
Add asCanonicalNameString() method on DockerImageName
77aa418
@rnorth
Use static factory method instead of constructor
592f08a
@rnorth
Use constant for docker registry image name
1edc307
@rnorth
Simplify image usage in ReusabilityUnitTests
113f3b3
@rnorth
Use DockerImageName instead of String for image name
fc7f625
@rnorth
Inline Mongo image name parsing
cd7e13b
@rnorth
Fix constructor delegation
a35b3c4
@rnorth
Undo deprecation of SocatContainer no-args constructor
868f962
@rnorth
Update references to DockerImageName.parse in example code
faf1217
@rnorth
Merge remote-tracking branch 'origin/master' into deprecate-ambiguous…
ee45003 
…-constructors
@rnorth
Merge remote-tracking branch 'origin/master' into deprecate-ambiguous…
8960ceb 
…-constructors
@cwacekINV
Copy link

Any status on this? The newest version of localstack (0.11.3) fixes localstack/localstack#1685, and we're running into a frustrating issue with some testcontainer-based tests (which are otherwise awesome!) because of that bug so would love to be able to use the latest localstack.

@rnorth
Copy link
Member

rnorth commented Jul 9, 2020

We have some changes coming in #2839 which deprecate default constructors, and will always encourage the user to specify an image, for all classes including LocalstackContainer.

Since the changes are not trivial, and this PR will be affected. I'll take an action to refactor this PR.

@rnorth rnorth self-assigned this Jul 9, 2020
@artamonovkirill
Copy link
Contributor Author

@cwacekINV, I ended up writing a custom wrapper around a GenericContainer:
https://github.com/artamonovkirill/ninshubur/blob/master/e2e/localstack/src/test/groovy/LocalStack.groovy

@rnorth
Copy link
Member

rnorth commented Jul 17, 2020

We'll merge this in behind #2839, most likely in an RC release this weekend. I've integrated #2839 into this PR, with several updates, so that we're ready to merge both together to master as quickly as possible.

@rnorth rnorth changed the title ⬆️ latest default LocalStack container Update to latest LocalStack container and support unified port mode Jul 19, 2020
@rnorth rnorth added this to the next milestone Jul 19, 2020
@rnorth rnorth changed the title Update to latest LocalStack container and support unified port mode Update to latest LocalStack container and support unified port mode (REVIEW AFTER #2839 MERGED) Jul 19, 2020
@rnorth rnorth changed the title Update to latest LocalStack container and support unified port mode (REVIEW AFTER #2839 MERGED) Update to latest LocalStack container and support unified port mode Jul 19, 2020
@rnorth
Copy link
Member

rnorth commented Jul 19, 2020

Merging - thansk @artamonovkirill!

@rnorth rnorth merged commit 39c4208 into testcontainers:master Jul 19, 2020
@artamonovkirill artamonovkirill deleted the chore/latest-localstack branch August 3, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees

@rnorth rnorth

Labels
None yet
Projects
None yet
Milestone
1.15.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artamonovkirill @cwacekINV @rnorth