Add support for Docker compose withOptions(...)
#2827
Conversation
| @@ -78,6 +78,7 @@ | |||
| private boolean localCompose; | |||
| private boolean pull = true; | |||
| private boolean build = false; | |||
| private String options = StringUtils.EMPTY; | |||
There was a problem hiding this comment.
Let's use a Set<String> to which to add the options. Or in case order would be important (it probably is not?) a List.
| * | ||
| * @return this instance, for chaining | ||
| */ | ||
| public SELF withOptions(String options) { |
There was a problem hiding this comment.
Just adding to the Set here would be enough.
String for runWithCompose can be constructed using Stream and Collectors.joining.
There was a problem hiding this comment.
Building on @kiview's suggestion to use a set, this also would mean that withOptions could take a varargs String, and just add all to the set. This would be quite nice semantically.
|
No problem, I will make the changes as soon as possible. Do I reuse the same branch then rebase to squash the commits together? What is the procedure you guys use? |
|
@Gapmeister66 we use 'Squash and Merge' when we merge, so there's no need for you to manually squash or rewrite your commits before then (unless you want to). |
|
Hello Richard How often do you guys run CI scripts over my branch ? I'm wondering whether CI has run over all of my commits thus far? The reason I ask is that my build failed at: 'Build and test with Gradle (:docs:examples:junit4:generic:check)'. It seems to have happened since my last commit (varargs), but that just might be a coincidence if this is my first CI build. There is no error logged as far as I can tell. I'm not a Gradle expert (I use Maven in my day job), does anybody have an idea of why my build failed? -- and I though this would be easy :) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
There was a problem hiding this comment.
LGTM. Sorry for the extreme amount of time it's taken to review again, @Gapmeister66
rnorth
changed the title
withOptions(...)
|
Fixed merge conflicts. |
Adds support for docker compose options using a 'with' fluent style syntax.
This enables a client to pass for example, the '--compatibility' option to the docker-compose command.
Parameterized Junit Test has been added.
Modified code in line with review @kiview
Changed options method to accept vargs @rnorth
I had some issues re-basing (squashing) my branch commits. The operation seemed to conflict with new changes in the master branch. I managed to commit in the end, but without squashed commits from my branch. Apologies if the git history is messy. If anybody can give me some advise in this area, please do :)