Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid clobbering already configured path #2957

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Jun 29, 2020

Almost fixes #2956

@findepi
Copy link
Contributor Author

findepi commented Sep 25, 2020

@kiview should i rebase?

@findepi
Copy link
Contributor Author

findepi commented Dec 11, 2020

No conflicts yet, ready for review.

@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jun 18, 2021
@findepi
Copy link
Contributor Author

findepi commented Jun 21, 2021

.

@stale stale bot removed the stale label Jun 21, 2021
@rnorth rnorth self-assigned this Jun 24, 2021
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will fail fast, rather than allow the user to do something which is known to be broken (#2956)?

I think this is fair for now, to reduce user confusion. We'll need to revisit #2956 later to actually fix the behaviour.

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @findepi.

@rnorth I agree, this should be fixed eventually, but this PR already improves the UX and does not add much complexity, so it's fine to add this for now.

@kiview kiview added this to the next milestone Sep 23, 2021
@kiview kiview merged commit 8f312b4 into testcontainers:master Sep 23, 2021
@findepi findepi deleted the findepi/master/avoid-clobbering-already-configured-path-b50286 branch September 24, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected result when withCopyFileToContainer invoked multiple times for the same path
3 participants