Convert Docs for the Junit5 #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert inline example code to use codeinclude macro for the kafka module documentation.
Implement the codeinclude plugin for the junit5 docs
raynigon
commented
Jul 9, 2020
| @@ -0,0 +1,37 @@ | |||
| package org.testcontainers.junit.jupiter; | |||
There was a problem hiding this comment.
unfortunately i had to create a new test class, to have the code representing nearly the same logic as the previous documentation
|
Difference in the docs, left (old) contains the inline code, right (new) was generated from the unit tests. |
rnorth
reviewed
Jul 10, 2020
modules/junit-jupiter/src/test/java/org/testcontainers/junit/jupiter/MixedLifecycleTests.java
Show resolved
Hide resolved
…upiter/MixedLifecycleTests.java
|
Merged - thanks @raynigon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert inline example code to use codeinclude macro for the JUnit5 Testframework documentation.
See #1158 for more details.