Couchbase: include error response from Couchbase in checkSuccessfulResponse() #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thrown exception, if present. Also minor logging cleanup, and prevented an exception from being swallowed. fixes testcontainers#2799
rnorth
approved these changes
Jul 18, 2020
|
Thanks @aaronjwhiteside, I think this looks sensible. |
rnorth
changed the title
rnorth
changed the title
sd-yip
added a commit
to sd-yip/testcontainers-java
that referenced
this pull request
May 12, 2021
…essfulResponse() (testcontainers#3006)" This reverts commit 6e8c18e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkSuccessfulResponse() now passes the body of the response to the thrown exception, if present.
Also minor logging cleanup, and prevented an exception from being swallowed.
fixes #2799