Remove dependency upon internet URLs for selenium tests #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
commented
Sep 26, 2020
Comment on lines
-54
to
-60
| protected static void doSimpleExplore(BrowserWebDriverContainer rule) { | ||
| RemoteWebDriver driver = setupDriverFromRule(rule); | ||
| driver.get("http://en.wikipedia.org/wiki/Randomness"); | ||
|
|
||
| // Oh! The irony! | ||
| assertTrue("Randomness' description has the word 'pattern'", driver.findElementByPartialLinkText("pattern").isDisplayed()); | ||
| } |
There was a problem hiding this comment.
There's no real sense in having two ways to test that Selenium is working, so just removed this altogether.
rnorth
commented
Sep 26, 2020
| /** | ||
| * Created by rnorth on 30/01/2016. | ||
| */ | ||
| public class FlakyContainerCreationTest { |
There was a problem hiding this comment.
This was old and ignored anyway, so have just removed.
rnorth
commented
Sep 26, 2020
| /** | ||
| * @author richardnorth | ||
| */ | ||
| public class LinkedContainerTest { |
There was a problem hiding this comment.
Given that all our tests will now use 'linked' (networked) containers, there's little point in having an explicit test for it that works another way.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
bsideup
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new shiny https://hub.docker.com/r/testcontainers/helloworld image