Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of HostPortWaitStrategy with Postgres container (fixes #3382) #3403

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix use of HostPortWaitStrategy with Postgres container (fixes #3382) #3403

merged 1 commit into from
Oct 29, 2020

Conversation

pawellozinski
Copy link
Contributor

No description provided.

@pawellozinski pawellozinski changed the title fix: Postgres wait strategy HostPortWaitStrategy doesn't work #3382 fix: Postgres wait strategy HostPortWaitStrategy doesn't work Oct 26, 2020
rnorth
rnorth approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thank you for the fix @pawellozinski

@rnorth rnorth changed the title fix: Postgres wait strategy HostPortWaitStrategy doesn't work Fix use of HostPortWaitStrategy with Postgres container (fixes #3382) Oct 29, 2020
@rnorth rnorth added this to the 1.15.0 milestone Oct 29, 2020
@rnorth rnorth merged commit 4a529f6 into testcontainers:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawellozinski @rnorth