couchbase: allow to customize the IndexStorageMode #3428
Conversation
daschl
force-pushed
the
couchbase-community
branch
from
dc06be2
to
aee199b
Compare
| String storageMode; | ||
| switch (indexStorageMode) { | ||
| case MEMORY_OPTIMIZED: | ||
| storageMode = "memory_optimized"; |
There was a problem hiding this comment.
@daschl would it make sense to move this constant into the enum itself and remove the need for a switch statement?
Or at least a static final Map with the mapping predefined
There was a problem hiding this comment.
I'm going to clean that up, rebase and get it freshned up.
This changeset allows to customize the index storage mode, which has been previously been defaulting to memory optimized. By allowing for customization pre startup, it achieves: - compatibility with the community edition by allowing the user to set it to forestdb - setting it to plasma which is another engine available in the enterprise edition The default still is memory optimized, since it seems to be the best option in a testing/CI environment. (relates to testcontainers#3419)
daschl
force-pushed
the
couchbase-community
branch
from
aee199b
to
f62b01e
Compare
|
Updated - is this good to go @aaronjwhiteside @bsideup ? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
keep alive! |
|
Hi @daschl! I am looking into the PR and looks like nowadays it is possible to use the |
This changeset allows to customize the index storage mode, which
has been previously been defaulting to memory optimized. By
allowing for customization pre startup, it achieves:
to set it to forestdb
enterprise edition
The default still is memory optimized, since it seems to be the
best option in a testing/CI environment.
(relates to #3419)