Switch from using Travis to GitHub Actions for release #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Dec 11, 2020
rnorth
commented
Jun 29, 2021
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| > Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container. | |||
|
|
|||
| [](https://travis-ci.org/testcontainers/testcontainers-java)[  ](https://bintray.com/testcontainers/releases/testcontainers/_latestVersion) | |||
There was a problem hiding this comment.
Just removing without replacing, as I doubt anybody will miss it.
rnorth
commented
Jun 29, 2021
build.gradle
Outdated
| @@ -60,8 +57,6 @@ subprojects { | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
It feels like this publishing block should probably be consolidated into publishing.gradle. Will do that, checking that there's not some weird side-effect in the set of generated artifacts.
Have confirmed that the resulting set of artifact filenames is the same, and we're still getting the shaded JAR for testcontainers core.
kiview
approved these changes
Jul 5, 2021
bsideup
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoing #2279 - need to follow up on https://github.community/t/read-timeout-issues-uploading-large-number-of-files-to-bintray-with-github-actions/17243/3#M5104