Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TrinoContainer, a container for Trino #3668

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Add TrinoContainer, a container for Trino #3668

merged 1 commit into from
Mar 31, 2021

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Jan 6, 2021

@findepi findepi force-pushed the trino branch 2 times, most recently from 378606f to 74d3bbe Compare January 6, 2021 21:59
@findepi findepi changed the title Add TrinoContainer Add TrinoContainer, a container for Trino Jan 6, 2021
@findepi
Copy link
Contributor Author

findepi commented Jan 11, 2021

@rnorth i do not need to be concerned about one "neutral check", do i?

@findepi findepi mentioned this pull request Jan 29, 2021
Merged
@bsideup bsideup mentioned this pull request Feb 6, 2021
Merged
@findepi
Copy link
Contributor Author

findepi commented Feb 6, 2021

thanks @bsideup for the review!
pushed changes as a fixup

@findepi
Copy link
Contributor Author

findepi commented Feb 11, 2021

AC

@findepi
Copy link
Contributor Author

findepi commented Feb 13, 2021

ac

@findepi
Copy link
Contributor Author

findepi commented Mar 8, 2021

@rnorth do you want me to rebase?

@findepi
Copy link
Contributor Author

findepi commented Mar 17, 2021

gentle ping for the review

@findepi
Copy link
Contributor Author

findepi commented Mar 19, 2021

@rnorth could you merge perhaps?

@findepi
Copy link
Contributor Author

findepi commented Mar 31, 2021

@bsideup can you merge please?

@bsideup bsideup added this to the next milestone Mar 31, 2021
@bsideup
Copy link
Member

bsideup commented Mar 31, 2021

@findepi yes, sorry! Merging 🎉

@bsideup bsideup merged commit eeb7eb2 into testcontainers:master Mar 31, 2021
@findepi findepi deleted the trino branch March 31, 2021 16:08
@rnorth rnorth mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
resolution/acknowledged type/enhancement type/new module
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@findepi @bsideup @losipiuk @rnorth