Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docs environment to python 3.7 #3871

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Bump docs environment to python 3.7 #3871

merged 2 commits into from
Mar 13, 2021

Conversation

xp-vit
Copy link
Contributor

@xp-vit xp-vit commented Mar 11, 2021 •
edited
Loading

This PR bumps docker-compose used for docs and contributing-docs document to Python 3.7.

Reason:

Used 'mkdocs-codeinclude-plugin' requires: Python >=3.7 (https://pypi.org/project/mkdocs-codeinclude-plugin/0.1.0/) and it's not possible to build docs currently with python 3.6.

rnorth
rnorth approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for spotting this and raising a PR. Approved.

@rnorth rnorth merged commit 60865fa into testcontainers:master Mar 13, 2021
@xp-vit xp-vit deleted the bump-python-to-3.7 branch March 13, 2021 10:59
@bsideup bsideup added this to the next milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/docs type/housekeeping
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xp-vit @rnorth @bsideup