filter mapped ports when port numbers are not specified #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
mentioned this pull request
bsideup
reviewed
Mar 31, 2021
| import static org.mockito.Mockito.when; | ||
| import static org.rnorth.visibleassertions.VisibleAssertions.*; | ||
|
|
||
| public class ContainerStateTest { |
There was a problem hiding this comment.
Could you please make this test parameterized?
bsideup
reviewed
Mar 31, 2021
| .map(Integer::valueOf) | ||
| .filter(port -> port.compareTo(0) > 0) |
There was a problem hiding this comment.
is there a reason why port > 0 cannot be used?
|
I'd like to expedite this as it causes clear problems and breaks the Testcontainers build with the latest Docker Desktop (on Mac at least). As people upgrade it'll start to cause more issues, and we should cut a release with this fix in place. @wrover thanks so much for the contribution - if you don't mind I might pick this PR up today and finish it off so that we can release soon. WDYT? |
rnorth
added a commit
that referenced
this pull request
Apr 11, 2021
…) (#3979) Co-authored-by: Ilia Rodionov <ilya.rodionov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue which happens on some verisons of docker on some platforms (particulalrly, on macOS X) when port mapping comes in form of
0.0.0.0:0:80.