Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin localstack to 0.12.8 #3981

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Pin localstack to 0.12.8 #3981

merged 3 commits into from
Apr 12, 2021

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Apr 11, 2021

It seems that our build is afflicted by localstack/localstack#3816
Localstack builds >=0.12.9 seem to have this issue, so pinning our test dependency to 0.12.8 for now.

@rnorth
Copy link
Member Author

rnorth commented Apr 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rnorth
Copy link
Member Author

rnorth commented Apr 11, 2021

Added a commit to use DockerClient to tag images rather than execing docker tag. As part of this I've also tidied up the test a little.

Note that I think we can further tidy this test - we should really aim to cut a lot of the execution time down by testing the LocalStackContainer.shouldRunInLegacyMode method directly, rather than having an integration test for so many different permutations. I think that should be done separately, though.

@rnorth rnorth merged commit 3347710 into master Apr 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-localstack-build branch April 12, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants