Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spock Testcontainers annotation is now inherited #4053

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Spock Testcontainers annotation is now inherited #4053

merged 1 commit into from
Jul 19, 2021

Conversation

tlefevre
Copy link
Contributor

@tlefevre tlefevre commented May 4, 2021

No description provided.

@tlefevre tlefevre mentioned this pull request May 4, 2021
Closed
@tlefevre
Copy link
Contributor Author

tlefevre commented May 4, 2021

There seems to be some general problems with the mysql check from what I can gather from other PRs.

@tlefevre
Copy link
Contributor Author

tlefevre commented Jun 3, 2021

This is a really simple PR that would be very useful, could I get a review on this?

kiview
kiview approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and good addition, thanks!

While we should cleanup the Spock tests in the future to use lighter images, this should not be of concern for this PR.

@kiview kiview merged commit b837bb1 into testcontainers:master Jul 19, 2021
@kiview kiview added this to the next milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
modules/spock Spock Extension resolution/awaiting-release type/enhancement
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tlefevre @bsideup @kiview