Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle Enterprise #4057

Merged
merged 15 commits into from
Nov 9, 2021
Merged

Add Gradle Enterprise #4057

merged 15 commits into from
Nov 9, 2021

Conversation

kiview
Copy link
Member

@kiview kiview commented May 5, 2021

Configures the Gradle Enterprise plugin to point at out GE instance and allows CI to push builds.

@kiview
Copy link
Member Author

kiview commented May 5, 2021

This is currently failing with:

The response from https://ge.testcontainers.org/scans/publish/gradle/3.6.1/token was not from Gradle Enterprise.
The specified server address may be incorrect, or your network environment may be interfering.

I had the same problem locally at it was related to using Oracle JDK 8 for the Gradle JVM (fixed it by upgrading Gradle JVM to Adopt Open JDK 14, but don't want to do this on CI).

@kiview
Copy link
Member Author

kiview commented May 6, 2021

This problem arose from Cloudflare blocking the JDK 8 user agent and we fixed this now in the infrastrucutre.

@kiview
Copy link
Member Author

kiview commented May 6, 2021

I did not add the GE key to the CI-Docker-Wormhole pipeline, mainly because the AWS keys also were not there. But we can of course add it later and map the key into the container.

@kiview kiview marked this pull request as ready for review May 6, 2021 15:46
@kiview kiview requested review from bsideup and rnorth as code owners May 6, 2021 15:46
Comment on lines +62 to +63
publishAlways()
publishIfAuthenticated()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be like this.

@kiview
Copy link
Member Author

kiview commented Oct 14, 2021

From my side, this can be merged to master.

The scans are publicly visible (as they were previously when we used the free service) here:
https://ge.testcontainers.org/scans

This change only reconfigures Gradle build scans for now. Build from authenticated Gradle daemons (in this case, maintainers after executing provisionGradleEnterpriseKeys task or CI) will be published to https://ge.testcontainers.org. If not authenticated, the build will not fail, and simply an info log will be displayed (as can be seen in the case of our wormhole tests):

A build scan was not published as you have not authenticated with server 'ge.testcontainers.org'.

In the future, we can think about conditionally either publishing to GE or the free service, if we ever see the need for this.

This PR does not yet introduce any changes to our build cache.

@kiview kiview merged commit 3ad90d7 into master Nov 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the gradle-enterprise branch November 9, 2021 10:58
@kiview kiview added this to the next milestone Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants