Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run update-* and release-drafter on original repository, not on forks #4104

Merged

Conversation

mrotteveel
Copy link
Contributor

@mrotteveel mrotteveel commented May 14, 2021

I think these jobs don't make much sense to run on forks, so to avoid unnecessary errors (as I received recently due to the Gradle Wrapper update), and save GitHub some money 😉, this change will make them only run on testcontainers/testcontainers-java

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's a good idea. Now I'm reminded that we have a similar issue with Dependabot (or at least my notification spam seems to imply it)!!!

I'm happy with this but curious: I'm guessing there's no other conditional expression we could use to avoid hardcoding the repo name three times? e.g. (using a property that I'm imagining) ! github.repository.is_fork or something like this.

@mrotteveel
Copy link
Contributor Author

Ah that's a good idea. Now I'm reminded that we have a similar issue with Dependabot (or at least my notification spam seems to imply it)!!!

As far as I recall about dependabot, you need to give it explicit permission per repository (or maybe per account) to access it. Or at least, I don't have dependabot 'spam' on my fork.

I'm happy with this but curious: I'm guessing there's no other conditional expression we could use to avoid hardcoding the repo name three times? e.g. (using a property that I'm imagining) ! github.repository.is_fork or something like this.

Not that I'm aware off, no.

@rnorth
Copy link
Member

rnorth commented May 19, 2021

Thanks for following up quickly @mrotteveel! Happy to merge.

@rnorth rnorth merged commit 137b00d into testcontainers:master May 19, 2021
@mrotteveel mrotteveel deleted the update-workflow-not-on-forks branch January 6, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants