Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for community edition of couchbase server #4221

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

Gerschtli
Copy link
Contributor

Follow up for #4041.

Copy link
Member

@daschl daschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@daschl
Copy link
Member

daschl commented Jul 8, 2021

@kiview I guess we can always refactor later, but right now the number of tests is very limited so that little bit of duplication shouldn't be a problem.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine to me, thank you @Gerschtli!

@rnorth rnorth merged commit 014500b into testcontainers:master Jul 16, 2021
@Gerschtli Gerschtli deleted the couchbase-community-rebased branch July 16, 2021 11:17
@bsideup bsideup added this to the next milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants