Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Windows CI into core and non-core steps #4293

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Jul 20, 2021

No description provided.

@rnorth
Copy link
Member Author

rnorth commented Jul 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a high overlap between the stages, would it make sense to extract them into a template?

Maybe we can think about it, if we would get a fourth task with duplicate elements.

@bsideup
Copy link
Member

bsideup commented Jul 20, 2021

@kiview I would rather spend time on GHA hosted workers migration then :)

@rnorth rnorth merged commit 3b3d130 into master Jul 20, 2021
@rnorth rnorth deleted the split-windows-ci branch July 20, 2021 12:54
gradleWrapperFile: 'gradlew'
jdkVersionOption: '1.11'
options: '--no-daemon --continue'
tasks: 'clean check -x testcontainers:test'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is testcontainers:test intentional? I would've expected testcontainers:check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants