Disable Chrome's GPU support in BrowserWebDriverContainer
#4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
changed the title
BaseWebDriverContainerTestBrowserWebDriverContainer
|
I added a very specific hack for the current Selenium web driver version in combination with Chrome into Of course, we can try to be even more specific in checking for the need for this hack, but so far, this is my first try, considering that Selenium have updated their existing tags. |
kiview
changed the title
BrowserWebDriverContainerBrowserWebDriverContainer
bsideup
reviewed
Jul 30, 2021
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
bsideup
approved these changes
Jul 30, 2021
bsideup
changed the title
BrowserWebDriverContainerBrowserWebDriverContainer
|
For documentation's sake, this seems to be the corresponding Chromium issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday's release of docker-selenium
3.141.59-20210729seems to fail to start under different circumstances and in different environments.A potential fix is setting
--disable-gpuin theChromeOptions.It is not yet clear what is the root cause of this issue (the update to Chrome 92?), but other users of docker-selenium report issues as well:
SeleniumHQ/docker-selenium#1346
This PR shall act as a way to further debug this issue in GitHub Actions and to discuss potential workarounds on our side.