Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Linux Azure pipelines build #4452

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Remove Linux Azure pipelines build #4452

merged 3 commits into from
Oct 20, 2021

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Sep 7, 2021

No description provided.

Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rnorth
Copy link
Member Author

rnorth commented Sep 7, 2021

Ninja fix incoming...

@rnorth
Copy link
Member Author

rnorth commented Sep 7, 2021

Updating, but I have a horrible feeling that this may not work well in conjunction with our self-hosted Windows CI execution.

Will kick off a Windows build later to find out.

@rnorth
Copy link
Member Author

rnorth commented Sep 7, 2021

/azp run

🤞

@azure-pipelines
Copy link

Command 'run

🤞' is not supported by Azure Pipelines.



Supported commands

  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@rnorth
Copy link
Member Author

rnorth commented Sep 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rnorth
Copy link
Member Author

rnorth commented Sep 7, 2021

Nope, it looks like it's run on Windows, but this naive change has caused our Windows build to run on Linux instead:
image

This will be a slightly more involved change - will move to draft so we can figure this out. We have until 20th September before the ubuntu-16.04 image becomes unavailable, I think.

@rnorth rnorth marked this pull request as draft September 7, 2021 17:11
@bsideup bsideup self-requested a review October 4, 2021 11:18
@rnorth rnorth marked this pull request as ready for review October 13, 2021 16:45
@rnorth
Copy link
Member Author

rnorth commented Oct 13, 2021

Not sure why this was still in draft. We have ~4 days to merge this before we hit the deprecation of the old ubuntu image in Azure pipelines, but that's OK.

@bsideup
Copy link
Member

bsideup commented Oct 13, 2021

@rnorth IIRC you moved it to draft because of our self hosted Windows node? 😅

@rnorth
Copy link
Member Author

rnorth commented Oct 13, 2021

Oh boy, I missed my own comment! Right, thanks!

4 days to merge 4 days to figure this out and merge 😅

@kiview
Copy link
Member

kiview commented Oct 13, 2021

Do we even have any good reason to continue maintaining Azure pipelines for the Linux build? It is basically replaced by GitHub Actions after all, isn't it?

@bsideup
Copy link
Member

bsideup commented Oct 13, 2021

With the exception of the manual trigger support (need to refresh my knowledge on the newly added features tho)

@rnorth
Copy link
Member Author

rnorth commented Oct 13, 2021

@kiview that is a very good question, which I admit I haven't given much thought to for a long time.

Unlike CircleCI I don't think we ever had any Docker/LXC quirks, so I think this Linux Azure Pipeline is mainly serving as usage documentation more than anything else.

@kiview
Copy link
Member

kiview commented Oct 13, 2021

@bsideup
We can run GHA manually (on PR? maybe just branch...) using workflow_dispatch, but AFAIK only via UI/Button (but with custom input fields).
But I was in this case actually referring to the Linux part of our Azure pipeline.

So my suggestion as a quick fix:

  • Remove Linux job from Azure pipelines and keep our current Windows process for now.

@rnorth
Yes, regarding the environment and configuration it should be extremely similar to GitHub Actions (since they also use Azure-hosted runners).

@rnorth
Copy link
Member Author

rnorth commented Oct 19, 2021

image

I'll amend this PR to remove the Azure Linux build, as this indeed seems like the right way forward.

The Azure Windows build should remain unchanged.

@rnorth rnorth changed the title Update ubuntu VM image used for Azure pipelines build Remove Linux Azure pipelines build Oct 19, 2021
@rnorth
Copy link
Member Author

rnorth commented Oct 19, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rnorth
Copy link
Member Author

rnorth commented Oct 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kiview kiview merged commit 31e5561 into master Oct 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-azp-linux branch October 20, 2021 16:19
@kiview kiview added this to the next milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants