-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AuthenticatedImagePullTest
#4560
Conversation
Previous implementation was assuming that Docker can pull from the gateway, which may not always be the case. This change makes the temporary registry run with host network, so that Docker can always pull from it.
Oh, this is interesting. There were failing tests about this feature on Docker for Windows, let me check if this fixes them as well. |
As mentioned on Slack, this has been working fine on Docker Desktop for Mac for absolutely ages, so if it's started to fail now I worry that we've encountered another regression/change in Docker Desktop. I'll see if I can reproduce the bug locally - I wonder if this might also be fixed by (TBD ticket ref for -p0: workaround) |
Ooh this is interesting:
Given that #4396 fixes other use cases that are currently broken, can we just advance with that? |
I can confirm that this PR fixes I can also confirm, that #4396 fixes Therefore, I am also in favor of merging #4396 instead and rely on this behavior, especially given that Docker wants to notify us in case of changes (as outlined in docker/for-mac#5588 (comment)):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the basis that this helps with remote docker/docker-wormhole models, I'm happy with this.
I wonder if this scenario, of requiring docker daemon to be able to talk to a specific container, is something that we might repeat in a couple of other places. Regardless though, if it is, we could extract whatever common glue code we need in order to share it.
Previous implementation was assuming that Docker can pull from the gateway, which may not always be the case (eg Docker Desktop).
This change makes the temporary registry run with host network, so that Docker can always pull from it.