Remove OkHttp transport #5113
Merged
Remove OkHttp transport #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
approved these changes
Mar 1, 2022
|
@rnorth do you have any objections? :) |
This was referenced Apr 13, 2022
smcvb
added a commit
to AxonIQ/axonserver-connector-java
that referenced
this pull request
Sep 30, 2022
This project used the shaded dependency from testcontainers on okhttp3. However, testcontainers decide to remove this entirely, in favor of Apache HttpClient 5. They made this decision, as Apache HttpClient 5 is apparently more stable (as you can read here https://github .com/testcontainers/testcontainers-java/pull/5113). I think it's fair we follow the same paradigm. While making this adjustment, we should clean-up the dependencies a little and resolve warnings in the touched files too. #dependency-upgrade/testcontainers
jaydeepk
added a commit
to znsio/specmatic
that referenced
this pull request
Jun 16, 2023
…and above. testcontainers/testcontainers-java#5113 AHC5 is what they are planing to continue with, hence replaced okhttp3 with apache httpclient 5 in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AHC5 was the default transport for 7 months now and we never had any reports about issues caused by it.
Since OkHttp transport's future in docker-java is unclear, and AHC5 covers everything, let's remove OkHttp transport option to reduce our set of dependencies.