Also allow copying transferables using withCopyFileToContainer #5180
Conversation
|
Just referencing #3815 here, so we keep the connection (and maybe we can integrate the test). |
| @@ -1284,15 +1279,97 @@ public SELF withWorkingDirectory(String workDir) { | |||
| return self(); | |||
| } | |||
|
|
|||
| private interface CopyFileToContainerWrapper<T> { | |||
There was a problem hiding this comment.
Can we find an interface name with more meaning for this? One might argue, that Transferable could have been a good abstraction already (we can transfer bytes of a file into the container), but of course, this is already used differently in our codebase now.
Maybe CopyFileToContainerSource ? If this is reflected in some parameters being renamed from wrapper to source, this should also help readability.
| @@ -174,6 +175,15 @@ default SELF withFileSystemBind(String hostPath, String containerPath) { | |||
| */ | |||
| SELF withCopyFileToContainer(MountableFile mountableFile, String containerPath); | |||
|
|
|||
| /** | |||
| * Set the file to be copied before starting a created container | |||
There was a problem hiding this comment.
| * Set the file to be copied before starting a created container | |
| * Set the Transferable to be copied before starting a created container |
It is not really a file, or?
Yeah there needs to be a test for sure - just wanted to reach some consensus that we're going in that direction before spending the time on it. |
Fixes #3814