Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jib integration #5623

Merged
merged 34 commits into from Mar 13, 2023
Merged

Add Jib integration #5623

merged 34 commits into from Mar 13, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Aug 1, 2022

Jib is a java library to build container images.

Provide JibDockerClient and JibImage to be used along with new GenericContainer(). Example:

GenericContainer<?> busybox = new GenericContainer<>(
    new JibImage(
        "busybox:1.35",
        jibContainerBuilder -> jibContainerBuilder.setEntrypoint("echo", "Hello World")
    )
)

modules/jib/build.gradle Outdated Show resolved Hide resolved
@eddumelendez eddumelendez changed the title JIB integration Add Jib integration Sep 5, 2022
@eddumelendez
Copy link
Member Author

if Jib.from(String) is used the image is downloaded using Jib's http client. Jib.from(DockerDaemonImage) uses new JibDockerClient#inspect which will use RemoteDockerImage(DockerImageName) to allow image name substitution.

@eddumelendez eddumelendez marked this pull request as ready for review September 5, 2022 23:25
@eddumelendez eddumelendez requested a review from a team as a code owner September 5, 2022 23:25
@eddumelendez
Copy link
Member Author

Also, classes now are in core module and the upgrade of jackson library is required in order to make it work with Jib.

core/build.gradle Outdated Show resolved Hide resolved
core/build.gradle Outdated Show resolved Hide resolved
core/build.gradle Outdated Show resolved Hide resolved
kiview
kiview previously approved these changes Mar 10, 2023
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go after resolving the remaining discussion points 👍

Through having JibContainerBuilder as part of the constructor of JibImage we add the Jib types to our public API, but I think this is ok in this case, since the author of jib-core is the owner of the Jib project and I don't see a big benefit in decoupling for us here.

core/build.gradle Outdated Show resolved Hide resolved
docs/features/jib.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Mar 10, 2023
@github-actions github-actions bot removed the github_actions Pull requests that update Github_actions code label Mar 10, 2023
kiview
kiview previously approved these changes Mar 10, 2023
kiview
kiview previously approved these changes Mar 10, 2023
@eddumelendez eddumelendez added this to the next milestone Mar 13, 2023
@eddumelendez eddumelendez merged commit f78c0c3 into main Mar 13, 2023
82 checks passed
@eddumelendez eddumelendez deleted the jib branch March 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants