New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jib integration #5623
Add Jib integration #5623
Conversation
modules/jib/src/main/java/org/testcontainers/jib/TcImageDetails.java
Outdated
Show resolved
Hide resolved
modules/jib/src/main/java/org/testcontainers/jib/TcDockerClient.java
Outdated
Show resolved
Hide resolved
modules/jib/src/main/java/org/testcontainers/jib/TcDockerClient.java
Outdated
Show resolved
Hide resolved
modules/jib/src/main/java/org/testcontainers/jib/JibDockerClient.java
Outdated
Show resolved
Hide resolved
if |
Also, classes now are in |
core/src/main/resources/META-INF/services/com.google.cloud.tools.jib.api.DockerClient
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/JibDockerClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go after resolving the remaining discussion points 👍
Through having JibContainerBuilder
as part of the constructor of JibImage
we add the Jib types to our public API, but I think this is ok in this case, since the author of jib-core
is the owner of the Jib project and I don't see a big benefit in decoupling for us here.
core/src/main/java/org/testcontainers/containers/JibDockerClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/BaseConfiguration.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Jib is a java library to build container images.
Provide
JibDockerClient
andJibImage
to be used along withnew GenericContainer()
. Example: