Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pull Request Template #5735

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Add Pull Request Template #5735

merged 5 commits into from
Aug 18, 2022

Conversation

eddumelendez
Copy link
Member

It provides some useful information about what to take into account
when submitting a PR.

It provides some useful information about what to take into account
when submitting a PR.
@eddumelendez eddumelendez requested a review from a team as a code owner August 16, 2022 22:48
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first start ❤️
I personally like that this is very much about having communication with the PR author and not an overwhelming PR template, which does not apply in many cases.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@kiview kiview added this to the next milestone Aug 18, 2022
eddumelendez and others added 4 commits August 18, 2022 10:04
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez eddumelendez merged commit 9fb5db1 into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the pr_template branch August 18, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants