Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add samples section #5763

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Add samples section #5763

merged 5 commits into from
Aug 23, 2022

Conversation

eddumelendez
Copy link
Member

List examples provided in testcontainers by providing an specific
section in the docs.

@eddumelendez
Add samples section
e39f576 
List examples provided in testcontainers by providing an specific
section in the docs.
@eddumelendez eddumelendez requested a review from a team as a code owner August 23, 2022 17:21
kiview
kiview approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice low-hanging fruit improvement for making our examples more discoverable. See my review suggestions and feel free to apply accordingly and merge.

docs/samples.md Outdated Show resolved Hide resolved
docs/samples.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
eddumelendez and others added 4 commits August 23, 2022 13:13
@eddumelendez @kiview
Update docs/samples.md
4f31b2b 
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez @kiview
Update docs/samples.md
f97801c 
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez @kiview
Update mkdocs.yml
f041c4b 
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez
Rename file
0fa8f33
@eddumelendez eddumelendez merged commit d568e9d into master Aug 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the samples_doc branch August 23, 2022 18:18
@eddumelendez eddumelendez added this to the next milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
1.17.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddumelendez @kiview