Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cratedb] Enable single node by default #7041

Merged
merged 1 commit into from
May 15, 2023
Merged

[cratedb] Enable single node by default #7041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/cratedb/src/main/java/org/testcontainers/cratedb/CrateDBContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class CrateDBContainer extends JdbcDatabaseContainer<CrateDBContainer> {

static final String IMAGE = "crate";

static final String DEFAULT_TAG = "5.2.5";
static final String DEFAULT_TAG = "5.3.1";

private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("crate");

Expand All @@ -34,6 +34,7 @@ public CrateDBContainer(final String dockerImageName) {
public CrateDBContainer(final DockerImageName dockerImageName) {
super(dockerImageName);
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME);
withCommand("crate -C discovery.type=single-node");

this.waitStrategy = Wait.forHttp("/").forPort(CRATEDB_HTTP_PORT).forStatusCode(200);

Expand Down
2 changes: 1 addition & 1 deletion modules/cratedb/src/test/java/org/testcontainers/junit/cratedb/SimpleCrateDBTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void testSimple() throws SQLException {
public void testCommandOverride() throws SQLException {
try (
CrateDBContainer cratedb = new CrateDBContainer(CrateDBTestImages.CRATEDB_TEST_IMAGE)
.withCommand("crate -C cluster.name=testcontainers")
.withCommand("crate -C discovery.type=single-node -C cluster.name=testcontainers")
) {
cratedb.start();

Expand Down