Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional listener should inherit the configured authentication method #7594

Merged
merged 8 commits into from Sep 28, 2023
Merged

Additional listener should inherit the configured authentication method #7594

merged 8 commits into from Sep 28, 2023

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Sep 28, 2023 •
edited

This PR implement the enhancement proposed in #7531 by setting the authentication_method for the additional listeners to the authentication method configured when sasl is enabled.

Fixes #7531

@lburgazzoli lburgazzoli requested a review from a team as a code owner September 28, 2023 17:08
@lburgazzoli lburgazzoli changed the title Additional listener should inherit the configured authentication method #7531 Additional listener should inherit the configured authentication method Sep 28, 2023
eddumelendez
eddumelendez reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @lburgazzoli! Those block are needed for our docs but using existing one will break the documentation.

modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java Outdated Show resolved Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java Outdated Show resolved Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java Outdated Show resolved Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java Outdated Show resolved Hide resolved
modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java Outdated Show resolved Hide resolved
@eddumelendez eddumelendez added this to the next milestone Sep 28, 2023
@eddumelendez eddumelendez merged commit 4296b5b into testcontainers:main Sep 28, 2023
12 of 13 checks passed
@eddumelendez
Copy link
Member

Thanks again, @lburgazzoli! This is now merged in main branch and will be part of the next release.

@lburgazzoli
Copy link
Contributor Author

@eddumelendez thx for fixing up my mistakes

@lburgazzoli lburgazzoli deleted the gh-7531 branch September 29, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
modules/redpanda type/bug
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

[Enhancement]: additional listener should inherit the configured authentication method
2 participants
@lburgazzoli @eddumelendez