Add shutdownHook to send sigterm to ryuk #7717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `Ryuk` container finishes after around 10s. This commit register a shutdown hook which will send a sigterm to the Ryuk container when JVM is terminating causing Ryuk to finish sooner.
kiview
approved these changes
Oct 26, 2023
|
Let's test this e2e, to ensure that the client is not closed by the time the hook is executed |
|
This should be reverted since it is causing issues in Spring projects. |
|
At least need to have the ability to disable it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Ryukcontainer finishes after around 10s. This commit registera shutdown hook which will send a sigterm to the Ryuk container when JVM
is terminating causing Ryuk to finish sooner (hence cleaning up all resources that weren't yet removed directly).