Changing default localstack credentials #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fokion
force-pushed
the
feat/localstack-creds
branch
3 times, most recently
from
1faf810
to
95fac26
Compare
fokion
force-pushed
the
feat/localstack-creds
branch
from
95fac26
to
0c50cb8
Compare
|
this is ready to be reviewed @eddumelendez |
…e do getAccessKey and getSecretKey we are checking the env map if we have the keys AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY respectively and fallback to the defaults
fokion
force-pushed
the
feat/localstack-creds
branch
from
0c50cb8
to
46ac860
Compare
...calstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
Outdated
Show resolved
Hide resolved
.../localstack/src/test/java/org/testcontainers/containers/localstack/LocalstackTestImages.java
Outdated
Show resolved
Hide resolved
...calstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
Outdated
Show resolved
Hide resolved
...calstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java
Outdated
Show resolved
Hide resolved
|
@fokion can you take a look at the other two suggestions, please? I can not commit them for some reason in the GH UI :/ |
|
Can you run |
eddumelendez
approved these changes
Oct 26, 2023
|
Thanks for your contribution, @fokion ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default credentials according to the localstack are test , when we do
getAccessKeyandgetSecretKeywe will need to check the environment map if we have the following keysand fallback to the default values defined in a static final variable with the value
testbased on this https://github.com/localstack/localstack/blob/master/doc/interaction/README.md?plain=1#L34