Add convenience method for creating JDBC connections #8164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbarbey
changed the title
rbarbey
force-pushed
the
feat/create-conn-convenient
branch
from
855cd28
to
b514d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a convenience method for creating JDBC connections that doesn't require any parameters. When writing test involving DB containers, I was unsure what to pass as
queryStringparameter and had to read the code to see that passing the empty string does what I need. After repeating a couple of times I thought this could be useful to have in general and make people's lives a tiny bit easier.Please let me know if this MR is missing something.
Thank you for taking the time to look at it!