CouchbaseContainer: Fix java.net.SocketException exception in stop() #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ========== When stop() was called without a prior call to createCouchbaseEnvironment(), it would throw a SocketException because stopCluster() would end up trying to initialize the cluster at the same time the container is being shut down. Modifications ============= Call stopCluster() before stopping the container, instead of in parallel. Result ====== stopCluster() might still call createCouchbaseEnvironment(), but the call succeeds and the environment is immediately cleaned up.
bsideup
changed the title
bsideup
reviewed
Sep 7, 2018
| @@ -12,4 +12,11 @@ public void shouldUseCorrectDockerImage() { | |||
| Assert.assertEquals(CouchbaseContainer.DOCKER_IMAGE_NAME + CouchbaseContainer.VERSION, | |||
| couchbaseContainer.getDockerImageName()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldStopWithoutThrowingException() { | |||
There was a problem hiding this comment.
since this test does not test anything automatically, I would remove it, just to not add time to the Testcontainers test suite
There was a problem hiding this comment.
I'm fine with removing it, as long as it's understood that this test fails prior the main code change in this PR.
There was a problem hiding this comment.
ah, ok, I thought that it is only about the logging, but if it fails with current master - let's keep it 👍
bsideup
approved these changes
Sep 9, 2018
|
@dnault merged, thanks 👍 |
|
We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
stop()was called without a prior call tocreateCouchbaseEnvironment(), it would throw aSocketExceptionbecausestopCluster()would end up trying to initialize the cluster at the same time the container is being shut down.Modifications
Call
stopCluster()before stopping the container, instead of in parallel.Result
stopCluster()might still callcreateCouchbaseEnvironment(), but the call succeeds and the environment is immediately cleaned up.