Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use customized wait strategy in jdbc container #8759

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

whhe
Copy link
Contributor

@whhe whhe commented Jun 6, 2024

Now the abstract class JdbcDatabaseContainer never uses the waitStrategy option, and I think it's better to use the user defined wait strategy when the waitStrategy field is modified.

@whhe
Copy link
Contributor Author

whhe commented Jun 6, 2024

Seems the last commit fails the japicmp check. Should I add these deleted methods to methodExcludes list? @eddumelendez

@whhe
Copy link
Contributor Author

whhe commented Jun 17, 2024

I reverted the latest commit of deleting the waitUntilContainerStarted method, so we can deal with it and the japicmp check later.

@whhe
Copy link
Contributor Author

whhe commented Jun 17, 2024

docker pull quay.io/testcontainers/ryuk:latest got exception:

latest: Pulling from testcontainers/ryuk
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of quay.io/testcontainers/ryuk:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

@whhe
Copy link
Contributor Author

whhe commented Jun 28, 2024

@eddumelendez PTAL

@whhe
Copy link
Contributor Author

whhe commented Jul 8, 2024

I just found #8127 which is trying to fix the same issue, feel free to accept it if you think it's better. @eddumelendez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant