-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use customized wait strategy in jdbc container #8759
base: main
Are you sure you want to change the base?
Conversation
Seems the last commit fails the |
I reverted the latest commit of deleting the waitUntilContainerStarted method, so we can deal with it and the japicmp check later. |
|
@eddumelendez PTAL |
I just found #8127 which is trying to fix the same issue, feel free to accept it if you think it's better. @eddumelendez |
Now the abstract class
JdbcDatabaseContainer
never uses thewaitStrategy
option, and I think it's better to use the user defined wait strategy when thewaitStrategy
field is modified.