fix LocalStack legacy mode detection for "latest" tag variations #8774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While looking into #7390 and digging into the legacy mode check for LocalStack I stumbled upon an issue when using specific
latest
images, like:localstack/localstack:s3-latest
(a minimal image which basically only contains S3)localstack/localstack-pro:latest-bigdata
(a LocalStack Pro image which contains disk-space heavy packages which would otherwise be downloaded on demand)If this is the case, the default fallback currently is to jump back to
useLegacyMode=true
which is not compatible with up-to-date images.In the long run, I would propose to change the default fallback (as mentioned in #7390 (comment)), but this PR aims at fixing the issue for these specific tags for now.
Changes
shouldRunInLegacyMode
action (and makes the function package private to allow directly testing it).