Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change password in MSSQLServerContainer #885

Merged
merged 6 commits into from
Feb 24, 2019
Merged

Allow to change password in MSSQLServerContainer #885

merged 6 commits into from
Feb 24, 2019

Conversation

ecostanzi
Copy link
Contributor

As for PostgresSQLContainer, this allow to change the default password in the SQL Server Container.

kiview
kiview approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@StefanHufschmidt ?

@ecostanzi ecostanzi changed the title Allow to password change in MSSQLServerContainer Allow to change password in MSSQLServerContainer Sep 28, 2018
@StefanHufschmidt
Copy link
Contributor

Since MS SQL Server requires a "strong" password we maybe should add a validation?

@kiview
Copy link
Member

kiview commented Sep 29, 2018

@StefanHufschmidt Good point, it won't boot else?

@StefanHufschmidt
Copy link
Contributor

Yes exactly. I don't know if it would be enough if the user of testcontainers would only see the startup error message.

Nevertheless I would like to have some tests for setting a custom password then. Maybe including one for a weak password as well.

In my opinion there should be a validation which throws an exception if the password is not "strong" so I can directly see where I have a mistake in my setup and not have to check the startup error.

@kiview
Copy link
Member

kiview commented Oct 1, 2018

Sounds good from a UX standpoint. Let's do it if the validation part is minimal (and we generate value by adding the setter for password).
@ecostanzi Would you like to contribute it in this PR as well?

@ecostanzi
Copy link
Contributor Author

Sure, I'll follow the rules I found here, right?

@kiview
Copy link
Member

kiview commented Oct 15, 2018

@ecostanzi Any news on this?

@ecostanzi
Copy link
Contributor Author

Hi, not yet, I hope to PR asap in the next few days

@testcontainers testcontainers deleted a comment Oct 21, 2018
@testcontainers testcontainers deleted a comment Oct 21, 2018
@testcontainers testcontainers deleted a comment Oct 21, 2018
@testcontainers testcontainers deleted a comment Oct 21, 2018
@testcontainers testcontainers deleted a comment Oct 21, 2018
@testcontainers testcontainers deleted a comment Oct 21, 2018
@kiview
Copy link
Member

kiview commented Oct 21, 2018

Hey @ecostanzi, PR looks pretty nice now, thanks.
@StefanHufschmidt WDYT?

kiview
kiview requested changes Oct 21, 2018
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style was a bit off (missing whitespaces).
We have an .editorconfig in the project root, but I'm not sure, if it would format those accordingly ATM.

modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java Outdated Show resolved Hide resolved
modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java Outdated Show resolved Hide resolved
modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java Outdated Show resolved Hide resolved
modules/mssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerTest.java Outdated Show resolved Hide resolved
@ecostanzi
Copy link
Contributor Author

Hi sorry I forgot to format the code. It should be ok now.

@testcontainers testcontainers deleted a comment Oct 22, 2018
@kiview kiview mentioned this pull request Oct 26, 2018
Merged
kiview
kiview requested changes Nov 4, 2018
View reviewed changes
modules/mssqlserver/build.gradle Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Feb 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Feb 4, 2019
@ecostanzi
Copy link
Contributor Author

Hi, i comment in order to keep this PR alive. This could be merged I just need to know if the tests are necessary or not.

@stale stale bot removed the stale label Feb 5, 2019
@kiview
Copy link
Member

kiview commented Feb 5, 2019

@ecostanzi Terribly sorry for the late answer, sometimes activity in issues gets missed 😞
Let's move the test class and then we are good to merge 👍

@testcontainers testcontainers deleted a comment Feb 16, 2019
@kiview kiview added this to the next milestone Feb 24, 2019
@kiview
Copy link
Member

kiview commented Feb 24, 2019

Circle-CI is failing because of missing Oracle image, tests not ignored yet on this branch.

@ecostanzi Thanks for your contribution, merged!

@kiview kiview merged commit 2d0dfc1 into testcontainers:master Feb 24, 2019
@ecostanzi ecostanzi deleted the mssql-password branch March 7, 2019 21:58
@rnorth
Copy link
Member

rnorth commented Mar 12, 2019

Released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.10.7!

@rnorth rnorth removed this from the next milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
modules/jdbc type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecostanzi @StefanHufschmidt @kiview @rnorth