Enable command override for PostgreSQLContainer #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
requested changes
Oct 26, 2018
modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
Outdated
Show resolved
Hide resolved
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
dbyron0
reviewed
Oct 26, 2018
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
kiview
requested changes
Oct 27, 2018
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
kiview
requested changes
Nov 2, 2018
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: kellen <kellen@users.noreply.github.com>
Co-Authored-By: kellen <kellen@users.noreply.github.com>
kiview
previously requested changes
Nov 4, 2018
modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java
Outdated
Show resolved
Hide resolved
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
Shall we complete this? @kellen please let us know if you don't have time - it is something I could pick up and finalise. |
|
@rnorth Yes, please do. I've just started a new job so this has been a low priority for me, sorry! |
…mand # Conflicts: # modules/jdbc-test/src/test/java/org/testcontainers/junit/SimplePostgreSQLTest.java # modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java
|
@kiview I've finished this off - please could you take another look? 😁 |
|
Fixes #937 |
bsideup
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects #937 for postgres removing the
setCommandcall inPostgreSQLContainer#configure()and thereby enabling command overrides.