Enable line terminator matching for LogMessageWaitStrategy #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Any thoughts on this? |
|
Hi @bengtbrodersen0042, Could you please add tests for it? |
|
I had to adjust a test only. |
|
I guess I'd just like to check that people won't have problems if they still have the line terminator in their patterns. What happens if people don't update their tests? It would be sad if this were a breaking change. |
|
I'm just going to add an additional test to make sure both cases are covered - looking good though. |
|
I've pushed a commit with additional test cases. |
|
Thx, I was quite busy |
|
I'm going to ignore the failing Travis test - it looks like Travis has gotten confused due to me mistakenly pushing a copy of this PR into a branch in the main repo. |
rnorth
approved these changes
Dec 23, 2018
|
Released in 1.10.4! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable line terminator matching to make expressions like ".*" matching even the end of a log line e.g. "waiting for connections on port 20017\n"