-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing registry from env variable to work with trailing slash #748
Fix parsing registry from env variable to work with trailing slash #748
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6472201
to
a802d93
Compare
@ilia-beliaev-miro do you know if this PR resolves #747 in its entirety? |
Hey @cristianrgreco, I can't test it with their setup. Maybe @ jonesbusy could check it? |
I don't think it resolve it. I was trying to remove the trailing slash from the env vars and the status was the same. Was hanging on the lock. Same if I remove the env vars (for the 10.8) While this PR will avoid creating double slash, it doesn't fix the issues I have. Right now I cannot explain further those regression with 10.7 and 10.8. Also why using same setup it work with testcontainer java et .net. Using 10.7 which doesn't use the env vars, error is that the "Started" log message is not received. Which made me think it was related to changes on the wait conditions. |
I found that it doesn't work with registries that have a path - auth config is then not found. Need to split the path part from the domain part. |
@ilia-beliaev-miro is this PR ok to merge/release? |
@cristianrgreco I am working on fixing the problem with the authentication with registry. Hope to push it in a couple of hours. |
…ustom registry. Now the domain part is properly separated from the path part of the image substitution prefix
Hey @cristianrgreco now it should be fine. |
Fixed the trailing slash in registry in env variable parsing behavior to work as specified in documentation.