Add ollama module #778
Merged
Add ollama module #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
enhancement
| .withWaitStrategy(Wait.forLogMessage("Listening on ")) | ||
| .withStartupTimeout(120_000); | ||
|
|
||
| getContainerRuntimeClient().then((client) => { |
There was a problem hiding this comment.
Although this should be fine because the container runtime client will be initialised before this constructor is invoked, it is still async and not guaranteed to resolve before start is called. I'd move this into the start method or one of the other lifecycle callbacks where it can be awaited.
There was a problem hiding this comment.
Thanks Cristian :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds Ollama Module based on module of TC java