Skip to content

Commit

Permalink
fix: inconsistent test runs for community modules (#497)
Browse files Browse the repository at this point in the history
- Fixed inconsistencies for community module test runs: using all
supported Python versions
- Pinned runner version (best practice)

fixes #482
  • Loading branch information
max-pfeiffer committed Mar 30, 2024
1 parent 472b2c2 commit 914f1e5
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci-community.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
track-modules:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout contents
uses: actions/checkout@v4
Expand All @@ -38,14 +38,14 @@ jobs:
outputs:
changed_modules: ${{ steps.compute-changes.outputs.computed_modules }}
test:
runs-on: ubuntu-22.04
needs: [track-modules]
if: ${{ needs.track-modules.outputs.changed_modules != '[]' }}
strategy:
fail-fast: false
matrix:
python-version: [ "3.11" ]
python-version: ["3.9", "3.10", "3.11", "3.12"]
module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }}
runs-on: ubuntu-latest
steps:
- name: Checkout contents
uses: actions/checkout@v4
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ on:

jobs:
test:
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
os: [ ubuntu ]
python-version: ["3.9", "3.10", "3.11", "3.12"]
runs-on: ${{ matrix.os }}-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
python:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Setup Env
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
jobs:
validate:
name: validate-pull-request-title
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: validate pull request title
uses: kontrolplane/pull-request-title-validator@ab2b54babb5337246f4b55cf8e0a1ecb0575e46d #v1
4 changes: 2 additions & 2 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
release:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
release_created: ${{ steps.track-release.outputs.release_created }}
steps:
Expand All @@ -16,7 +16,7 @@ jobs:
manifest-file: .github/.release-please-manifest.json
config-file: .github/release-please-config.json
publish:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
environment: release
permissions:
id-token: write
Expand Down

0 comments on commit 914f1e5

Please sign in to comment.