fix: Fix the return type of DockerContainer.get_logs (#487)

testcontainers · Mar 24, 2024 · cd72f68 · cd72f68
1 parent 1d10c1c
commit cd72f68
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/core/testcontainers/core/container.py b/core/testcontainers/core/container.py
@@ -148,7 +148,7 @@ def get_wrapped_container(self) -> "Container":
     def get_docker_client(self) -> DockerClient:
         return self._docker
 
-    def get_logs(self) -> tuple[str, str]:
+    def get_logs(self) -> tuple[bytes, bytes]:
         if not self._container:
             raise ContainerStartException("Container should be started before getting logs")
         return self._container.logs(stderr=False), self._container.logs(stdout=False)

diff --git a/core/tests/test_core.py b/core/tests/test_core.py
@@ -28,4 +28,6 @@ def test_can_get_logs():
     with DockerContainer("hello-world") as container:
         wait_for_logs(container, "Hello from Docker!")
         stdout, stderr = container.get_logs()
+        assert isinstance(stdout, bytes)
+        assert isinstance(stderr, bytes)
         assert stdout, "There should be something on stdout"