Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Module 'typing_extensions' not found, not listed as dependency #533

Closed
Tracked by #534
yvanoers opened this issue Apr 9, 2024 · 1 comment · Fixed by #534 or #535
Closed
Tracked by #534

Bug: Module 'typing_extensions' not found, not listed as dependency #533

yvanoers opened this issue Apr 9, 2024 · 1 comment · Fixed by #534 or #535

Comments

@yvanoers
Copy link

yvanoers commented Apr 9, 2024

Describe the bug

I got this error today:

Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/integration_test.py:6: in <module>
    from testcontainers.localstack import LocalStackContainer
../../../../.local/lib/python3.10/site-packages/testcontainers/localstack/__init__.py:19: in <module>
    from testcontainers.core.container import DockerContainer
../../../../.local/lib/python3.10/site-packages/testcontainers/core/container.py:7: in <module>
    from typing_extensions import Self
E   ModuleNotFoundError: No module named 'typing_extensions'

Our testcontainers dependency is not pinned to a version, and today it pulled in 4.3.2 and failed with above error.
After rolling back to 4.3.1 the error was gone.

The problem seems to be that typing_extensions is not listed as dependency in pyproject.toml.

To Reproduce

Use testcontainers in a clean environment, meaning that it doesn't have any preinstalled typing_extensions module.
In our case, this is a Github Actions runner.

Runtime environment

Doesn't seem relevant at this time, but will provide if necessary.

alexanderankin pushed a commit that referenced this issue Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.3.3](testcontainers-v4.3.2...testcontainers-v4.3.3)
(2024-04-09)


### Bug Fixes

* missing typing-extensions dependency
([#534](#534))
([ef86d15](ef86d15)),
closes
[#533](#533)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@alexanderankin
Copy link
Collaborator

@yvanoers terribly sorry, fix is out though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants