-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch container #19
Conversation
Hello @nivm! Thanks for updating the PR.
Comment last updated on May 04, 2018 at 06:51 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
========================================
- Coverage 82.69% 77.5% -5.2%
========================================
Files 13 14 +1
Lines 260 280 +20
Branches 15 17 +2
========================================
+ Hits 215 217 +2
- Misses 35 54 +19
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
Failed test is |
@nivm Thank you for PR, could you please add some tests for elastic search container? See example for DB or Selenium |
add the Redis and General container types
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 82.69% 73.84% -8.86%
==========================================
Files 13 15 +2
Lines 260 302 +42
Branches 15 20 +5
==========================================
+ Hits 215 223 +8
- Misses 35 66 +31
- Partials 10 13 +3
Continue to review full report at Codecov.
|
Revert "add the Redis and General container types"
Add an implementation of the elasticsearch container.