Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch container #19

Merged
merged 9 commits into from
Nov 2, 2018
Merged

Conversation

nivm
Copy link
Contributor

@nivm nivm commented May 4, 2018

Add an implementation of the elasticsearch container.

@pep8speaks
Copy link

pep8speaks commented May 4, 2018

Hello @nivm! Thanks for updating the PR.

Line 28:80: E501 line too long (83 > 79 characters)

Comment last updated on May 04, 2018 at 06:51 Hours UTC

@nivm nivm closed this May 4, 2018
@nivm nivm reopened this May 4, 2018
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #19 into master will decrease coverage by 5.19%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #19     +/-   ##
========================================
- Coverage   82.69%   77.5%   -5.2%     
========================================
  Files          13      14      +1     
  Lines         260     280     +20     
  Branches       15      17      +2     
========================================
+ Hits          215     217      +2     
- Misses         35      54     +19     
+ Partials       10       9      -1
Impacted Files Coverage Δ
testcontainers/elasticsearch.py 0% <0%> (ø)
testcontainers/core/waiting_utils.py 100% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c081c18...f4c1bf0. Read the comment docs.

@nivm
Copy link
Contributor Author

nivm commented May 4, 2018

Failed test is tests/test_new_docker_api.py::test_docker_env_variables doesnt related to my change.
Also, It is an environment issue as this test pass in our Jenkins environment.

@SergeyPirogov
Copy link
Collaborator

@nivm Thank you for PR, could you please add some tests for elastic search container? See example for DB or Selenium

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #19 into master will decrease coverage by 8.85%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   82.69%   73.84%   -8.86%     
==========================================
  Files          13       15       +2     
  Lines         260      302      +42     
  Branches       15       20       +5     
==========================================
+ Hits          215      223       +8     
- Misses         35       66      +31     
- Partials       10       13       +3
Impacted Files Coverage Δ
testcontainers/redis.py 0% <0%> (ø)
testcontainers/elasticsearch.py 0% <0%> (ø)
testcontainers/core/docker_client.py 83.33% <0%> (-16.67%) ⬇️
testcontainers/core/container.py 77.02% <0%> (-4.52%) ⬇️
testcontainers/core/utils.py 66.66% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c081c18...f3f1f06. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants