Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move self.with_exposed_ports to initializer #260

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

yakimka
Copy link
Collaborator

@yakimka yakimka commented Oct 31, 2022

Fixes behavior from #257 when with_bind_ports is not working

@yakimka yakimka changed the title Draft: Move self.with_exposed_ports to initializer Move self.with_exposed_ports to initializer Oct 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #260 (d792464) into master (472da35) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files          28       28           
  Lines         782      782           
  Branches       77       77           
=======================================
  Hits          672      672           
  Misses         81       81           
  Partials       29       29           
Impacted Files Coverage Δ
testcontainers/clickhouse.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tillahoffmann tillahoffmann merged commit de8939d into master Nov 4, 2022
@tillahoffmann tillahoffmann deleted the clickhouse-ports branch November 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants